This revision was automatically updated to reflect the committed changes.
Closed by commit rL328494: [SemaCXX] _Pragma("clang optimize off")
not affecting lambda. (authored by CarlosAlbertoEnciso, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.
CarlosAlbertoEnciso added a comment.
Thanks @erichkeane for your review.
Repository:
rC Clang
https://reviews.llvm.org/D43821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CarlosAlbertoEnciso added a comment.
Ping.
Thanks
Repository:
rC Clang
https://reviews.llvm.org/D43821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CarlosAlbertoEnciso added a comment.
Ping.
Thanks
Repository:
rC Clang
https://reviews.llvm.org/D43821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CarlosAlbertoEnciso updated this revision to Diff 137550.
CarlosAlbertoEnciso added a comment.
Correct the issues raised by the reviews.
Repository:
rC Clang
https://reviews.llvm.org/D43821
Files:
lib/Sema/SemaLambda.cpp
test/CodeGenCXX/optnone-pragma-optimize-off.cpp
Index: test/CodeG
CarlosAlbertoEnciso added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12598
+// have to apply optnone due to a pragma.
+AddRangeBasedOptnone(FD);
+
erichkeane wrote:
> Should thi sonly happen if this is a definition? Additionally, does this
> neg
erichkeane added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:12598
+// have to apply optnone due to a pragma.
+AddRangeBasedOptnone(FD);
+
Should thi sonly happen if this is a definition? Additionally, does this
negate the need for the other call
CarlosAlbertoEnciso added a comment.
Ping.
Thanks
Repository:
rC Clang
https://reviews.llvm.org/D43821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
CarlosAlbertoEnciso created this revision.
CarlosAlbertoEnciso added reviewers: rsmith, erichkeane, andreadb.
CarlosAlbertoEnciso added a project: clang.
Declaring "_Pragma("clang optimize off")" before the body of a
function with a lambda leads to the lambda functions in the body
not being affect
