[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

2018-02-19 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325490: [CodeComplete] Add a helper to print CodeCompletionContext::Kind (authored by ibiryukov, committed by ). Changed prior to commit: https://reviews.llvm.org/D43379?vs=134888&id=134891#toc Reposit

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

2018-02-19 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 134888. ilya-biryukov added a comment. - Rename printCompletionKind to getCompletionKindString Repository: rC Clang https://reviews.llvm.org/D43379 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/CodeCompleteConsumer.cpp Index: lib/

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

2018-02-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:355 +/// \brief Get string representation of \p Kind, useful for for debugging. +llvm::StringRef printCompletionKind(enum CodeCompletionContext::Kind Kind); + ilya-biryukov wro

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

2018-02-19 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added inline comments. Comment at: include/clang/Sema/CodeCompleteConsumer.h:355 +/// \brief Get string representation of \p Kind, useful for for debugging. +llvm::StringRef printCompletionKind(enum CodeCompletionContext::Kind Kind); + sammccall wro

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

2018-02-19 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Sema/CodeCompleteConsumer.h:355 +/// \brief Get string representation of \p Kind, useful for for debugging. +llvm::StringRef printCompleti

[PATCH] D43379: [CodeComplete] Add a helper to print CodeCompletionContext::Kind

2018-02-16 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added a reviewer: sammccall. Herald added a subscriber: ioeric. Will be used in clangd. See https://reviews.llvm.org/D43377. Repository: rC Clang https://reviews.llvm.org/D43379 Files: include/clang/Sema/CodeCompleteConsumer.h lib/Sema/C