rjmccall added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8185
+unsigned FreeRegs) const {
+ // TODO: C++ ABI?
+ unsigned SizeInRegs = (getContext().getTypeSize(Ty) + 31) / 32;
Please do go ahead an
petecoup added a comment.
Hi Tatyana,
Thanks for taking a look here, and sorry for the delay.
I tried to follow the other target's usage patterns here.
I'm happy to update/change this...I'll add a couple of clang reviewers here to
weigh in?
https://reviews.llvm.org/D43089
__
tatyana-krasnukha added a comment.
Sorry, =default is not applicable in these cases, of course.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8123
+public:
+ ARCABIInfo(CodeGen::CodeGenTypes &CGT) : DefaultABIInfo(CGT) {}
+
tatyana-krasnukha wrote:
> Better use
tatyana-krasnukha added a comment.
This is what I could note
Comment at: clang/lib/Basic/Targets/ARC.h:26
+class LLVM_LIBRARY_VISIBILITY ARCTargetInfo : public TargetInfo {
+ static const Builtin::Info BuiltinInfo[];
+
Looks like unused member, while getTarget
petecoup added a comment.
Hi Tatyana,
Thanks for checking against lldb! I will try and find a couple of people who
can review this as a clang change.
Pete
https://reviews.llvm.org/D43089
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
tatyana-krasnukha added a comment.
Hello Pete,
Thank you for upstreaming ARC target to clang! I checked it in couple with lldb
- works well. So, the revision is good to me. But it seems, I have no rights to
accept revisions yet...
https://reviews.llvm.org/D43089
___
petecoup updated this revision to Diff 133674.
petecoup added a comment.
Hello Eugene,
Thanks for taking a look.
Changed // End anonymous namespace. -> // namespace
https://reviews.llvm.org/D43089
Files:
clang/lib/Basic/CMakeLists.txt
clang/lib/Basic/Targets.cpp
clang/lib/Basic/Targets/A
Eugene.Zelenko added inline comments.
Comment at: clang/lib/CodeGen/TargetInfo.cpp:8220
+
+} // End anonymous namespace.
Please change to // namespace
https://reviews.llvm.org/D43089
___
cfe-commits mailing list
petecoup created this revision.
petecoup added a reviewer: tatyana-krasnukha.
Herald added subscribers: hintonda, mgorny.
https://reviews.llvm.org/D43089
Files:
clang/lib/Basic/CMakeLists.txt
clang/lib/Basic/Targets.cpp
clang/lib/Basic/Targets/ARC.cpp
clang/lib/Basic/Targets/ARC.h
clang
