hgabii updated this revision to Diff 153863.
hgabii added a comment.
Sorry, I forgot about my pull request.
I fixed the issues what are identified by reviewers :
- Check moved to bugprone module
- () and `` added
- matchesName replaced with hasAnyName
-Unnecessary IDs depracated
- clang-tidy/
alexfh requested changes to this revision.
alexfh added inline comments.
This revision now requires changes to proceed.
Comment at: clang-tidy/misc/IoFunctionsMisusedCheck.cpp:33
+ has(cxxMemberCallExpr(
+ on(hasType(namedDecl(matchesName("istream"))
Eugene.Zelenko added a comment.
May be //bugprone// is better module then //misc//?
Comment at: docs/ReleaseNotes.rst:63
+
+ Check if the fgetwc, getwc, getwchar, istream::get standard iostream C
functions
+ return values incorrectly stored in char type value.
-
malcolm.parsons added a comment.
Why only the wide versions?
Even narrow versions return an int so that you can check for EOF.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42682
___
cfe-commits mailing list
cfe-commits@lists.llvm.
hgabii created this revision.
hgabii added a reviewer: clang-tools-extra.
hgabii added a project: clang-tools-extra.
Herald added subscribers: cfe-commits, hintonda, mgorny, srhines.
Add misc-io-functions-misused checker to warns for cases when the return value
of certain standard iostream C func
