benhamilton marked 3 inline comments as done.
benhamilton added a comment.
Thanks for the review!
Comment at: lib/Format/Format.cpp:765
GoogleStyle.ColumnLimit = 100;
+GoogleStyle.BinPackObjCProtocolList = FormatStyle::BPS_Never;
}
stephanemoore wro
benhamilton updated this revision to Diff 132046.
benhamilton added a comment.
Move Google style changes out. Use clearer name for local variable.
Repository:
rC Clang
https://reviews.llvm.org/D42650
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Fo
stephanemoore requested changes to this revision.
stephanemoore added inline comments.
This revision now requires changes to proceed.
Comment at: lib/Format/ContinuationIndenter.cpp:1232
+
+bool BinPackParameters =
+(State.Line->Type != LT_ObjCDecl && Style.BinPackPar
benhamilton updated this revision to Diff 131841.
benhamilton added a comment.
Rebase
Repository:
rC Clang
https://reviews.llvm.org/D42650
Files:
include/clang/Format/Format.h
lib/Format/ContinuationIndenter.cpp
lib/Format/Format.cpp
unittests/Format/FormatTestObjC.cpp
Index: unitte
benhamilton created this revision.
benhamilton added reviewers: krasimir, jolesiak, stephanemoore.
This is an alternative approach to https://reviews.llvm.org/D42014 after some
investigation by stephanemoore@ and myself.
Previously, the format parameter `BinPackParameters` controlled both
C funct
