This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE323865: [clang-move] Clever on handling header file which
includes itself. (authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42639?vs=132111&id=132136#toc
Reposi
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lg
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42639
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
hokein updated this revision to Diff 132111.
hokein marked an inline comment as done.
hokein added a comment.
address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D42639
Files:
clang-move/ClangMove.cpp
clang-move/ClangMove.h
unittests/clang-move/ClangMov
hokein marked an inline comment as done.
hokein added inline comments.
Comment at: clang-move/ClangMove.cpp:708
+// Find old.h includes "old.h".
+if (AbsoluteOldHeader == AbsoluteOldHeader) {
+ OldHeaderIncludeRangeInHeader = IncludeFilenameRange;
io
ioeric added inline comments.
Comment at: clang-move/ClangMove.cpp:708
+// Find old.h includes "old.h".
+if (AbsoluteOldHeader == AbsoluteOldHeader) {
+ OldHeaderIncludeRangeInHeader = IncludeFilenameRange;
This check is always true?
==
hokein created this revision.
hokein added a reviewer: ioeric.
Herald added a subscriber: klimek.
Previously, we assume only old.cc includes "old.h", which would
introduce incorrect fixes for the cases where old.h also includes `#include
"old.h"`
Although it should not be occurred in real projec
