[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-15 Thread Brian Gesiak via Phabricator via cfe-commits
modocache added a comment. Hooray, `[dcl.fct.def.coroutine]/7` is *in!* Thank you for all the reviews, @GorNishanov! Repository: rC Clang https://reviews.llvm.org/D42606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-15 Thread Brian Gesiak via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC325291: [Coroutines] Use allocator overload when available (authored by modocache, committed by ). Changed prior to commit: https://reviews.llvm.org/D42606?vs=134304&id=134495#toc Repository: rC Clan

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-15 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov accepted this revision. GorNishanov added a comment. This revision is now accepted and ready to land. LGTM Repository: rC Clang https://reviews.llvm.org/D42606 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-14 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 134304. modocache added a comment. Thanks for the review, @GorNishanov, and for pointing out that part of the standard! I added a reference to the implicit object parameter, as well as some tests for that behavior. And thanks for pointing out the flaw in

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-13 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:1062 + // an argument list." + for (auto *PD : FD.parameters()) { +if (PD->getType()->isDependentType()) GorNishanov wrote: > This does not implement TS specified behavior for non sta

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-13 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added inline comments. Comment at: lib/Sema/SemaCoroutine.cpp:1062 + // an argument list." + for (auto *PD : FD.parameters()) { +if (PD->getType()->isDependentType()) This does not implement TS specified behavior for non static member functions:

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-06 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 133154. modocache added a comment. Update the tests to work with scalar parameter copies. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp test/CodeGenCoroutines/coro-gro

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-06 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 133129. modocache added a comment. Prevent coroutine parameter stores from being moved, rely on https://reviews.llvm.org/D43000 instead. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-01 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov added inline comments. Comment at: lib/CodeGen/CGCoroutine.cpp:526 EmitBlock(AllocBB); - auto *AllocateCall = EmitScalarExpr(S.getAllocate()); + // Emit the call to the coroutine frame allocation function. + auto *AllocateCall = cast(EmitScalarExpr(S.getAllocate

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-02-01 Thread Gor Nishanov via Phabricator via cfe-commits
GorNishanov requested changes to this revision. GorNishanov added inline comments. This revision now requires changes to proceed. Comment at: lib/CodeGen/CGCoroutine.cpp:526 EmitBlock(AllocBB); - auto *AllocateCall = EmitScalarExpr(S.getAllocate()); + // Emit the call to the

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-01-28 Thread Brian Gesiak via Phabricator via cfe-commits
modocache updated this revision to Diff 131729. modocache added a comment. Add some diagnostics tests to SemaCXX/coroutines.cpp. Repository: rC Clang https://reviews.llvm.org/D42606 Files: lib/CodeGen/CGCoroutine.cpp lib/Sema/SemaCoroutine.cpp test/CodeGenCoroutines/coro-alloc.cpp te

[PATCH] D42606: [Coroutines] Use allocator overload when available

2018-01-26 Thread Brian Gesiak via Phabricator via cfe-commits
modocache created this revision. modocache added reviewers: rsmith, GorNishanov, eric_niebler. Herald added a subscriber: EricWF. Depends on https://reviews.llvm.org/D42605. An implementation of the behavior described in `[dcl.fct.def.coroutine]/7`: when a promise type overloads `operator new` us