This revision was automatically updated to reflect the committed changes.
Closed by commit rL323713: [CUDA] Added partial support for CUDA-9.1 (authored
by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42513?vs=131894&id=131896#
This revision was automatically updated to reflect the committed changes.
Closed by commit rC323713: [CUDA] Added partial support for CUDA-9.1 (authored
by tra, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42513?vs=131894&id=131895#toc
Repository:
rL LLVM
https://revie
tra updated this revision to Diff 131894.
tra added a comment.
Rebased to HEAD.
https://reviews.llvm.org/D42513
Files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Basic/Targets/NVPTX.cpp
clang/lib/Driver/ToolChains/Cuda.cpp
clang/lib/Headers/CMakeLists.txt
c
tra updated this revision to Diff 131650.
tra added a comment.
Addressed Justin's comments.
https://reviews.llvm.org/D42513
Files:
clang/include/clang/Basic/Cuda.h
clang/lib/Basic/Cuda.cpp
clang/lib/Basic/Targets/NVPTX.cpp
clang/lib/Driver/ToolChains/Cuda.cpp
clang/lib/Headers/CMakeLi
jlebar added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32
+
+#define __DEVICE__ static __device__ __forceinline__
+// There are number of functions that became compiler builtins in CUDA-9 and
are
tra wrote:
> jlebar wrote:
>
tra added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32
+
+#define __DEVICE__ static __device__ __forceinline__
+// There are number of functions that became compiler builtins in CUDA-9 and
are
jlebar wrote:
> tra wrote:
> > j
jlebar added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32
+
+#define __DEVICE__ static __device__ __forceinline__
+// There are number of functions that became compiler builtins in CUDA-9 and
are
tra wrote:
> jlebar wrote:
>
tra marked 2 inline comments as done.
tra added inline comments.
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:32
+
+#define __DEVICE__ static __device__ __forceinline__
+// There are number of functions that became compiler builtins in CUDA-9 and
are
---
jlebar added a comment.
Gosh I think the chances we get through this without a copy-paste error are way
too high. I'm not sure what to do about it, though. I don't have the focus to
check this as carefully as it needs.
Perhaps we need to test this in the test-suite (eventually)? We've seen t
tra created this revision.
tra added reviewers: jlebar, jholewinski.
Herald added subscribers: hintonda, mgorny, sanjoy.
Clang can use CUDA-9.1 now, though new builtins (__hmma_m32n8k16*) are not
implemented yet.
The major change is that headers in CUDA-9.1 went through substantial
changes that
10 matches
Mail list logo