hintonda abandoned this revision.
hintonda added a comment.
Not needed for llvm+clang builds.
Repository:
rC Clang
https://reviews.llvm.org/D42490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
hintonda added a comment.
In https://reviews.llvm.org/D42490#994154, @beanz wrote:
> Historically we've duplicated `cmake_policy` calls on a per-project basis
> which we needed to support standalone builds. That said, it would be nice if
> we had LLVM vend some CMake modules that encapsulated t
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
Historically we've duplicated `cmake_policy` calls on a per-project basis which
we needed to support standalone builds. That said, it would be nice if we had
LLVM vend some CMake modules that en
hintonda added a comment.
It turns out that policies don't survive a call to `cmake_minimum_required()`,
so we need to rethink how llvm, et al, handles policies, e.g.:
- move `cmake_minimum_required()` inside the `if( CMAKE_SOURCE_DIR STREQUAL
CMAKE_CURRENT_SOURCE_DIR )` branch.
- move all `cma
hintonda created this revision.
hintonda added reviewers: beanz, compnerd, phosek, EricWF.
Herald added subscribers: cfe-commits, mgorny.
Set cmake policy CMP0068=NEW, if available -- depends on
https://reviews.llvm.org/D42463 which
also adds target property "BUILD_WITH_INSTALL_NAME_DIR On" to ma