[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131359. devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D42467#987140, @krytarowski wrote: > I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now > an option to rebuild these libraries against sanitizers and so stop teaching > the world how to handle its API. > > Please kee

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131358. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp === --- lib/Driver/ToolChains/CommonAr

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now an option to rebuild these libraries against sanitizers and so stop teaching the world how to handle its API. Please keep these patches locally for now. Repository: rC Clang https://rev

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131356. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp === --- lib/Driver/ToolChains/CommonAr

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131239. devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/Driver/ToolChains/CommonArgs.cpp Index: lib/Driver/ToolChains/CommonArgs.cpp

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. In https://reviews.llvm.org/D42467#986280, @devnexen wrote: > In https://reviews.llvm.org/D42467#986279, @krytarowski wrote: > > > Please update the `-lutil` comment in the code according to the comment. I > > can land this for you once it will be accepted. > > > In

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D42467#986279, @krytarowski wrote: > Please update the `-lutil` comment in the code according to the comment. I > can land this for you once it will be accepted. In fact the review comment is wrong/confusing :-) lutil is for forkpty only as

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread Kamil Rytarowski via Phabricator via cfe-commits
krytarowski added a comment. Please update the `-lutil` comment in the code according to the comment. I can land this for you once it will be accepted. Repository: rC Clang https://reviews.llvm.org/D42467 ___ cfe-commits mailing list cfe-commits

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen updated this revision to Diff 131229. devnexen retitled this revision from "FreeBSD needs also execinfo and libutil" to "FreeBSD needs also execinfo, libutil and libkvm". devnexen edited the summary of this revision. Repository: rC Clang https://reviews.llvm.org/D42467 Files: lib/D

[PATCH] D42467: FreeBSD needs also execinfo, libutil and libkvm

2018-01-24 Thread David CARLIER via Phabricator via cfe-commits
devnexen added a comment. In https://reviews.llvm.org/D42467#986214, @krytarowski wrote: > Do you plan to use MSan? If so, `-lkvm` might be useful as well. This is indeed the plan. Updated. Repository: rC Clang https://reviews.llvm.org/D42467