This revision was automatically updated to reflect the committed changes.
Closed by commit rL323387: FreeBSD needs also execinfo (in sanitizers)
(authored by kamil, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D42467?vs=131359&id=131
devnexen updated this revision to Diff 131359.
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
devnexen added a comment.
In https://reviews.llvm.org/D42467#987140, @krytarowski wrote:
> I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now
> an option to rebuild these libraries against sanitizers and so stop teaching
> the world how to handle its API.
>
> Please kee
devnexen updated this revision to Diff 131358.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
===
--- lib/Driver/ToolChains/CommonAr
krytarowski added a comment.
I propose to skip now `-lkvm` and `-lutil` for FreeBSD. I'm researching now an
option to rebuild these libraries against sanitizers and so stop teaching the
world how to handle its API.
Please keep these patches locally for now.
Repository:
rC Clang
https://rev
devnexen updated this revision to Diff 131356.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
===
--- lib/Driver/ToolChains/CommonAr
devnexen updated this revision to Diff 131239.
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/CommonArgs.cpp
Index: lib/Driver/ToolChains/CommonArgs.cpp
krytarowski added a comment.
In https://reviews.llvm.org/D42467#986280, @devnexen wrote:
> In https://reviews.llvm.org/D42467#986279, @krytarowski wrote:
>
> > Please update the `-lutil` comment in the code according to the comment. I
> > can land this for you once it will be accepted.
>
>
> In
devnexen added a comment.
In https://reviews.llvm.org/D42467#986279, @krytarowski wrote:
> Please update the `-lutil` comment in the code according to the comment. I
> can land this for you once it will be accepted.
In fact the review comment is wrong/confusing :-) lutil is for forkpty only as
krytarowski added a comment.
Please update the `-lutil` comment in the code according to the comment. I can
land this for you once it will be accepted.
Repository:
rC Clang
https://reviews.llvm.org/D42467
___
cfe-commits mailing list
cfe-commits
devnexen updated this revision to Diff 131229.
devnexen retitled this revision from "FreeBSD needs also execinfo and libutil"
to "FreeBSD needs also execinfo, libutil and libkvm".
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/D
devnexen added a comment.
In https://reviews.llvm.org/D42467#986214, @krytarowski wrote:
> Do you plan to use MSan? If so, `-lkvm` might be useful as well.
This is indeed the plan. Updated.
Repository:
rC Clang
https://reviews.llvm.org/D42467
krytarowski added a comment.
Do you plan to use MSan? If so, `-lkvm` might be useful as well.
Comment at: lib/Driver/ToolChains/CommonArgs.cpp:552
CmdArgs.push_back("-ldl");
// Required for forkpty on some OSes
+ if (TC.getTriple().getOS() == llvm::Triple::NetBSD ||
--
devnexen updated this revision to Diff 131220.
devnexen retitled this revision from "FreeBSD needs also execinfo" to "FreeBSD
needs also execinfo and libutil".
devnexen edited the summary of this revision.
Repository:
rC Clang
https://reviews.llvm.org/D42467
Files:
lib/Driver/ToolChains/Com
devnexen created this revision.
devnexen added reviewers: joerg, vitalybuka.
devnexen created this object with visibility "All Users".
Herald added subscribers: cfe-commits, krytarowski, emaste.
As NetBSD, FreeBSD needs execinfo for backtrace's matters.
Repository:
rC Clang
https://reviews.ll
15 matches
Mail list logo
