This revision was automatically updated to reflect the committed changes.
Closed by commit rL323319: [clang-format] Disable string literal breaking for
text protos (authored by krasimir, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D4237
krasimir updated this revision to Diff 131216.
krasimir added a comment.
- Update comment
Repository:
rC Clang
https://reviews.llvm.org/D42373
Files:
lib/Format/Format.cpp
Index: lib/Format/Format.cpp
===
--- lib/Format/Form
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Change the comment and possibly also the patch description along the lines of
what I have suggested. Other than that, looks good to me.
Comment at: lib/Format/Format.cpp:6
krasimir added a comment.
So, we found out other cases where this is especially painful:
- breaking long URLs into multiple lines
- updating the text of a paragraph and breaking again with combination of
no-reflow
We could disable it for now and enable it when we have string literal reflow.
R
krasimir added a comment.
Let's not do this then. For reflowing string literals, it could take a
two-three months.
Repository:
rC Clang
https://reviews.llvm.org/D42373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
djasper added a comment.
I am not sure we should actually do this. I agree that badly reflowing
multiline string literals is not ideal, but neither is violating the column
limit. In any case, proper reflowing would probably the best solution. How hard
would it be to implement that (for proto as
krasimir created this revision.
krasimir added a reviewer: djasper.
Herald added subscribers: cfe-commits, klimek.
Commonly string literals in protos are already multiline, so breaking them
further is undesirable.
Repository:
rC Clang
https://reviews.llvm.org/D42373
Files:
lib/Format/Forma
