[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

2018-01-22 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL323133: [CodeComplete] Fix completion in the middle of idents in macro calls (authored by ibiryukov, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM https://reviews.llvm.or

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

2018-01-22 Thread Benjamin Kramer via Phabricator via cfe-commits
bkramer accepted this revision. bkramer added a comment. This revision is now accepted and ready to land. I think we can go ahead with this. I expect code completion in the middle of a token not to be used much though, so there might be more broken cases. Repository: rC Clang https://reviews

[PATCH] D42241: [CodeComplete] Fix completion in the middle of idents in macro calls

2018-01-18 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: bkramer, arphaman. This patch removes IdentifierInfo from completion token after remembering the identifier in the preprocessor. Prior to this patch, completion token had the IdentifierInfo set to null when completing at the star