ABataev added a comment.
In https://reviews.llvm.org/D42168#978689, @Hahnfeld wrote:
> In https://reviews.llvm.org/D42168#978634, @ABataev wrote:
>
> > 1. Please, mark the record as packed.
>
>
> Where and how do I need to do this? I found that `PackedAttr` is checked on
> `FieldDecl`s but I'm n
Hahnfeld marked an inline comment as done.
Hahnfeld added a comment.
In https://reviews.llvm.org/D42168#978634, @ABataev wrote:
> 1. Please, mark the record as packed.
Where and how do I need to do this? I found that `PackedAttr` is checked on
`FieldDecl`s but I'm not sure if we go through tha
ABataev added a comment.
1. Please, mark the record as packed.
2. Tests
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3576-3577
EntryInit.addInt(CGM.Int32Ty, 0);
- llvm::GlobalVariable *Entry =
-EntryInit.finishAndCreateGlobal(".omp_offloading.entry",
-
ABataev added a comment.
Or, there is another one solution - mark `_tgt_offload_entry` record as packed.
Repository:
rC Clang
https://reviews.llvm.org/D42168
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/ma
ABataev added a comment.
In https://reviews.llvm.org/D42168#978594, @Hahnfeld wrote:
> In https://reviews.llvm.org/D42168#978593, @ABataev wrote:
>
> > After some investigation, I think this whole code is incorrect. We should
> > not rely on the fact that there is no padding on some architecture
Hahnfeld added a comment.
In https://reviews.llvm.org/D42168#978593, @ABataev wrote:
> After some investigation, I think this whole code is incorrect. We should not
> rely on the fact that there is no padding on some architectures and should
> mix the type generated by the Clang and initial val
ABataev added a comment.
After some investigation, I think this whole code is incorrect. We should not
rely on the fact that there is no padding on some architectures and should mix
the type generated by the Clang and initial value, generated by LLVM.
Repository:
rC Clang
https://reviews.ll
Hahnfeld created this revision.
Hahnfeld added reviewers: gtbercea, ABataev, carlo.bertolli.
Herald added subscribers: cfe-commits, guansong.
If there are multiple files with target regions, each file and
region must generate a unique name or the linker will complain.
Repository:
rC Clang
htt
