This revision was automatically updated to reflect the committed changes.
Closed by commit rC322661: [Sema] Add visited contexts to CodeCompleteContext
(authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D42071?vs=130155&id=130170#toc
Repository:
rC Clang
hokein added inline comments.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:271
+ using VisitedContextSet = llvm::SmallPtrSet;
+
ilya-biryukov wrote:
> Given that lookup does not visit the same `DeclContext` twice, we're probably
> fine with vector he
hokein updated this revision to Diff 130155.
hokein marked 5 inline comments as done.
hokein retitled this revision from " [Sema] Add visited contexts to
CodeCompleteContext" to "[Sema] Add visited contexts to CodeCompleteContext".
hokein edited the summary of this revision.
hokein added a comment
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM.
Look at the comments for a few NITs.
Comment at: include/clang/Sema/CodeCompleteConsumer.h:271
+ using VisitedContextSet = llvm::SmallPtrSet;
+
---
