phosek added a comment.
In https://reviews.llvm.org/D42019#1162644, @mcgrathr wrote:
> Is this still live? Should it be different after all the multiarch stuff?
I'm about to revive this and was pondering if maybe we should generalize this
to all targets now that the multiarch runtime bit has l
mcgrathr added a comment.
Is this still live? Should it be different after all the multiarch stuff?
Repository:
rC Clang
https://reviews.llvm.org/D42019
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
phosek added inline comments.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152
+ llvm::sys::path::append(P, normalizeTriple(Triple));
+ return P.str();
+}
mcgrathr wrote:
> The GCC behavior (if --with-sysroot is given to configure) is
> tooldir/sys-root, not
mcgrathr added inline comments.
Comment at: lib/Driver/ToolChains/Fuchsia.cpp:152
+ llvm::sys::path::append(P, normalizeTriple(Triple));
+ return P.str();
+}
The GCC behavior (if --with-sysroot is given to configure) is tooldir/sys-root,
not tooldir itself.
phosek created this revision.
phosek added a reviewer: mcgrathr.
Herald added a subscriber: cfe-commits.
When sysroot isn't explicitly set, try to use the default location which is
/../
Repository:
rC Clang
https://reviews.llvm.org/D42019
Files:
lib/Driver/ToolChains/Fuchsia.cpp
Index:
