[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

2018-01-18 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322853: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse (authored by ibiryukov, committed by ). Herald added a subscriber: ioeric. Changed prior to commit: https://reviews.llvm.org/

[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

2018-01-15 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov marked an inline comment as done. ilya-biryukov added inline comments. Comment at: include/clang/Frontend/PrecompiledPreamble.h:107 /// is accessible. - /// For in-memory preambles, PrecompiledPreamble instance continues to own - /// the MemoryBuffer with the P

[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

2018-01-15 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 129817. ilya-biryukov marked 2 inline comments as done. ilya-biryukov added a comment. - Remove redundant assertion message Repository: rC Clang https://reviews.llvm.org/D41990 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/Pr

[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

2018-01-15 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov updated this revision to Diff 129815. ilya-biryukov added a comment. - Simplify comments Repository: rC Clang https://reviews.llvm.org/D41990 Files: include/clang/Frontend/PrecompiledPreamble.h lib/Frontend/PrecompiledPreamble.cpp Index: lib/Frontend/PrecompiledPreamble.cp

[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

2018-01-12 Thread Sam McCall via Phabricator via cfe-commits
sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land. Comment at: include/clang/Frontend/PrecompiledPreamble.h:107 /// is accessible. - /// For in-memory preambles, PrecompiledPreamble instance continues to own -

[PATCH] D41990: [Frontend] Allow to use PrecompiledPreamble without calling CanReuse

2018-01-12 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov created this revision. ilya-biryukov added reviewers: bkramer, sammccall. The new method 'OverridePreamble' allows to override the preamble of any source file without checking if preamble bounds or dependencies were changed. This is used for completion in clangd. Repository: rC