This revision was automatically updated to reflect the committed changes.
Closed by commit rL322371: [CodeComplete] Add an option to omit results from
the preamble. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D41
This revision was automatically updated to reflect the committed changes.
Closed by commit rC322371: [CodeComplete] Add an option to omit results from
the preamble. (authored by sammccall, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41989?vs=129618&id=129620#toc
Reposito
sammccall updated this revision to Diff 129618.
sammccall added a comment.
Load -> LoadExternal
Repository:
rC Clang
https://reviews.llvm.org/D41989
Files:
include/clang-c/Index.h
include/clang/Sema/CodeCompleteConsumer.h
include/clang/Sema/CodeCompleteOptions.h
include/clang/Sema/Se
ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.
LGTM modulo the comment about variable name.
Comment at: lib/Sema/SemaLookup.cpp:3502
+ bool IncludeDependentBases,
+
sammccall added a comment.
This is basically all plumbing, so I've marked the two lines that actually do
something :-)
Comment at: lib/Sema/SemaLookup.cpp:3517
// Ensure all external identifiers are in the identifier table.
-if (IdentifierInfoLookup *External = Idents
sammccall created this revision.
sammccall added reviewers: bkramer, ilya-biryukov.
Herald added a subscriber: cfe-commits.
Enumerating the contents of a namespace or global scope will omit any
decls that aren't already loaded, instead of deserializing them from the
PCH.
This allows a fast hybrid
