This revision was automatically updated to reflect the committed changes.
Closed by commit rC322797: [analyzer] operator new: Fix callback order for
CXXNewExpr. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41934
Files:
lib/StaticAnalyzer/Checkers/An
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
Looks great. It is nice to have this fixed and cleaned up!
Comment at: lib/StaticAnalyzer/Checkers/AnalysisOrderChecker.cpp:95
+ llvm::errs() << "PreCall";
+
NoQ added inline comments.
Comment at: test/Analysis/cxxnewexpr-callback-inline.cpp:31-32
+// CHECK-NEXT: PostStmt
+// CHECK-NEXT: PreCall (foo)
+// CHECK-NEXT: PostCall (foo)
This ensures that there are no other callbacks after `PostStmt`, in
particular that th
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs, eraman.
Even if we later change how these callbacks work (as in
http://lists.llvm.org/pipermail/cfe-dev/2017-December/056314.html), i wanted
