Re: [PATCH] D41837: Add Function multiversion to the release notes.

2018-01-17 Thread Hans Wennborg via cfe-commits
nesday, January 17, 2018 4:47 AM > To: reviews+d41837+public+36225483e5851...@reviews.llvm.org > Cc: Keane, Erich ; Richard Smith > ; Aaron Ballman ; Eric > Christopher ; cfe-commits > Subject: Re: [PATCH] D41837: Add Function multiversion to the release notes. > > Did this f

RE: [PATCH] D41837: Add Function multiversion to the release notes.

2018-01-17 Thread Keane, Erich via cfe-commits
; Richard Smith ; Aaron Ballman ; Eric Christopher ; cfe-commits Subject: Re: [PATCH] D41837: Add Function multiversion to the release notes. Did this functionality land before the 6.0 branch, that is, should we copy the release notes to the branch? Thanks Hans On Tue, Jan 9, 2018 at 12:37 AM

Re: [PATCH] D41837: Add Function multiversion to the release notes.

2018-01-17 Thread Hans Wennborg via cfe-commits
Did this functionality land before the 6.0 branch, that is, should we copy the release notes to the branch? Thanks Hans On Tue, Jan 9, 2018 at 12:37 AM, Erich Keane via Phabricator wrote: > This revision was automatically updated to reflect the committed changes. > Closed by commit rC322043: Doc

[PATCH] D41837: Add Function multiversion to the release notes.

2018-01-08 Thread Erich Keane via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC322043: Document attribute target multiversioning. (authored by erichkeane, committed by ). Changed prior to commit: https://reviews.llvm.org/D41837?vs=128982&id=128995#toc Repository: rC Clang http

[PATCH] D41837: Add Function multiversion to the release notes.

2018-01-08 Thread Richard Smith - zygoloid via Phabricator via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. Looks fine. Can you also update include/clang/Basic/AttrDocs.td to mention multiversioning in `TargetDocs`? Then you can add a few words here to say "consult the documentation for the target a

[PATCH] D41837: Add Function multiversion to the release notes.

2018-01-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane updated this revision to Diff 128982. erichkeane added a comment. Ah, right :) Slipped my mind that ELF != x86-linux. https://reviews.llvm.org/D41837 Files: docs/ReleaseNotes.rst Index: docs/ReleaseNotes.rst === ---

[PATCH] D41837: Add Function multiversion to the release notes.

2018-01-08 Thread Eric Christopher via Phabricator via cfe-commits
echristo added a comment. I think you're missing that right now it's x86 only yes? :) -eric Repository: rC Clang https://reviews.llvm.org/D41837 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D41837: Add Function multiversion to the release notes.

2018-01-08 Thread Erich Keane via Phabricator via cfe-commits
erichkeane created this revision. erichkeane added reviewers: rsmith, hans, aaron.ballman, echristo. Richard suggested that I add this feature to the release notes, so I was hoping someone (anyone willing:) ) could do a quick read through for me. Thanks! -Erich Repository: rC Clang https://r