This revision was automatically updated to reflect the committed changes.
Closed by commit rC322795: [analyzer] Suppress "this" pointer escape
during construction. (authored by dergachev, committed by ).
Repository:
rC Clang
https://reviews.llvm.org/D41797
Files:
lib/StaticAnalyzer/Core/Cal
dcoughlin accepted this revision.
dcoughlin added a comment.
This revision is now accepted and ready to land.
LGTM!
Repository:
rC Clang
https://reviews.llvm.org/D41797
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org
a.sidorin added a comment.
Hi Artem,
I think that global suppression is fine. If one really wants to check such
escapes, he can implement a separate callback for this.
Repository:
rC Clang
https://reviews.llvm.org/D41797
___
cfe-commits mailing
xazax.hun added a comment.
I am fine with suppressing the escape globally.
I did see some code in the wild where the constructors registered the objects
with a (global) map.
But I think it is still easier to annotate code that does something
unconventional than the other way around.
Repository
NoQ created this revision.
NoQ added reviewers: dcoughlin, xazax.hun, a.sidorin, george.karpenkov, szepet.
Herald added subscribers: cfe-commits, rnkovacs.
This one's easy. Under `-analyzer-config c++-allocator-inlining=true`, since
https://reviews.llvm.org/D41406, we've teached `MallocChecker` t
