This revision was automatically updated to reflect the committed changes.
Closed by commit rL322742: [DeclPrinter] Fix two cases that crash clang
-ast-print. (authored by tra, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D41788?vs=12
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
This should be fine.
https://reviews.llvm.org/D41788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
tra added a comment.
@bkramer Can you take a look at the patch?
https://reviews.llvm.org/D41788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tra added a comment.
@arphaman: ping.
https://reviews.llvm.org/D41788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jlebar added a comment.
I strongly approve of fixing these crashes, but I don't think I can say with
confidence whether this change is correct.
https://reviews.llvm.org/D41788
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llv
tra created this revision.
tra added a reviewer: arphaman.
Herald added subscribers: jlebar, sanjoy.
Both crashes are related to handling anonymous structures.
- clang didn't handle () around an anonymous struct variable.
- clang also crashed on syntax errors that could lead to other syntactic
c
