This revision was automatically updated to reflect the committed changes.
Closed by commit rCTE321092: [clangd] Build dynamic index and use it for code
completion. (authored by ioeric, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41289?vs=127554&id=127555#toc
Repository:
ioeric updated this revision to Diff 127554.
ioeric marked 4 inline comments as done.
ioeric added a comment.
- Address review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41289
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
ioeric added a comment.
Thanks for the quick review!
Comment at: clangd/ClangdUnit.cpp:617
+ new CppFile(FileName, std::move(Command), StorePreamblesInMemory,
+ std::move(PCHs), std::move(ASTCallback)));
}
sammccall wrote:
> CppFile doesn
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
OK, this is pretty clean now! :-)
Comment at: clangd/ClangdServer.cpp:139
+ FileIdx(BuildDynamicSymbolIndex ? new FileIndex() : nullptr),
+ Units(FileIdx
+
ioeric updated this revision to Diff 127544.
ioeric added a comment.
- Merge with https://reviews.llvm.org/D41289.
- Merge with origin/master
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41289
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServe
ioeric updated this revision to Diff 127493.
ioeric added a comment.
- Merge with updated https://reviews.llvm.org/D41281
- Fix broken merge
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41289
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer
ioeric created this revision.
ioeric added a reviewer: sammccall.
Herald added subscribers: cfe-commits, ilya-biryukov, klimek.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41289
Files:
clangd/ClangdLSPServer.cpp
clangd/ClangdLSPServer.h
clangd/ClangdServer.cpp
clangd/C
