Re: [PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

Hi Ana On 17 January 2018 at 23:14, Ana Pazos via Phabricator via cfe-commits wrote: > apazos added a comment. > > Committed R32276 This commit broke ARM/AArch64 buildbots. riscv-gnutools.c test fails on these boxes. logs are available here: http://lab.llvm.org:8011/builders/clang-cmake-aarch64

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos added a comment. Committed R322769 Repository: rL LLVM https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

This revision was automatically updated to reflect the committed changes. Closed by commit rL322769: [RISCV] Propagate -mabi and -march values to GNU assembler. (authored by apazos, committed by ). Changed prior to commit: https://reviews.llvm.org/D41271?vs=129981&id=130272#toc Repository: r

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos added a comment. Thanks for the clarifications Alex. No need to fix these known issues right now. I will proceed with checking in this change. https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb added a comment. In https://reviews.llvm.org/D41271#977222, @apazos wrote: > I tested this on windows and I had to add an assembler placeholder > executable, just like it was done with the linker in the RISCV multilib dir > checked under Inputs. > Other observations, are these known issue

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos updated this revision to Diff 129981. apazos added a comment. I tested this on windows and I had to add an assembler placeholder executable, just like it was done with the linker in the RISCV multilib dir checked under Inputs. Other observations, are these known issues? - multilib dir c

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos added a comment. thanks Alex, I will test on windows before pushing. https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb added a comment. I've just had a painful time landing https://reviews.llvm.org/D39963 due to failures on the Windows buildbots. I think you'll have problems on Windows with the tests in this patch, as Windows surely won't default to /usr/bin/as. Sadly I don't have access to a windows Clang

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos updated this revision to Diff 129476. apazos added a comment. Herald added a subscriber: niosHD. Rebased. https://reviews.llvm.org/D41271 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/riscv-gnutools.c Index: test/Driver/riscv-gnutools.c ==

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos added a comment. This is ready to merge, just waiting for the dependence https://reviews.llvm.org/D39963 to be merged first. https://reviews.llvm.org/D41271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

apazos updated this revision to Diff 127170. apazos added a comment. changed label prefix ILP64 to LP64 https://reviews.llvm.org/D41271 Files: lib/Driver/ToolChains/Gnu.cpp test/Driver/riscv-gnutools.c Index: test/Driver/riscv-gnutools.c ===

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb added inline comments. Comment at: test/Driver/riscv-gnutools.c:6 +// RUN: %clang -target riscv64-unknown-elf -fno-integrated-as %s -### \ +// RUN: 2>&1 | FileCheck -check-prefix=MABI-ILP64 %s + s/MABI-ILP64/MABI-LP64 https://reviews.llvm.org/D41271

[PATCH] D41271: [RISCV] Propagate -mabi and -march values to GNU assembler.

asb edited subscribers, added: cfe-commits; removed: llvm-commits. asb added a comment. Removing llvm-commits and adding cfe-commits. Thanks Ana. This looks good to me. We probably should have a default march, but I don't know what it should be. If most clang targets default to a Linux-capable