[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Yi Kong via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rC320753: [ThreadSafetyAnalysis] Fix isCapabilityExpr (authored by kongyi, committed by ). Repository: rC Clang https://reviews.llvm.org/D41224 Files: lib/Sema/SemaDeclAttr.cpp test/Sema/attr-capabi

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. This LGTM, but you should wait to commit for a few days in case @delesley has any concerns. Repository: rC Clang https://reviews.llvm.org/D41224 __

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Yi Kong via Phabricator via cfe-commits
kongyi added a comment. In https://reviews.llvm.org/D41224#955213, @lebedev.ri wrote: > Hi. > I don't want to hijack the thread, but is PR32954 > likely unrelated to this fix, > and the problem (if it is a bug) is likely elsewhere? Should be unre

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Roman Lebedev via Phabricator via cfe-commits
lebedev.ri added a comment. Hi. I don't want to hijack the thread, but is PR32954 likely unrelated to this fix, and the problem (if it is a bug) is likely elsewhere? Repository: rC Clang https://reviews.llvm.org/D41224 ___

[PATCH] D41224: [ThreadSafetyAnalysis] Fix isCapabilityExpr

2017-12-14 Thread Yi Kong via Phabricator via cfe-commits
kongyi created this revision. kongyi added a reviewer: delesley. kongyi added a project: clang. Herald added a subscriber: cfe-commits. There are many more expr types that can be a capability expr, like CXXThisExpr, CallExpr, MemberExpr. Instead of enumerating all of them, just check typeHasCapabi