This revision was automatically updated to reflect the committed changes.
Closed by commit rL320694: [clangd] Construct SymbolSlab from YAML format.
(authored by hokein, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D41178?vs=126927&id=126929#toc
Repository:
rL LLVM
http
hokein updated this revision to Diff 126927.
hokein marked 2 inline comments as done.
hokein added a comment.
MappingTraits is not Symbol's friend.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41178
Files:
clangd/CMakeLists.txt
clangd/index/Index.cpp
clangd/index/Index.
sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.
Comment at: clangd/index/Index.h:17
#include "llvm/ADT/StringExtras.h"
+#include "llvm/Support/YAMLTraits.h"
This isn't needed anymore (if you r
hokein added a comment.
Thanks for the comments!
Comment at: clangd/index/SymbolFromYAML.cpp:32
+// supported in YAML I/O.
+struct NPArray {
+ NPArray(IO &) {}
sammccall wrote:
> what does NP stand for?
Ah, P is a typo here. N stands for Normalized. Renamed it
hokein updated this revision to Diff 126909.
hokein marked 5 inline comments as done.
hokein added a comment.
Address the review comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D41178
Files:
clangd/CMakeLists.txt
clangd/index/Index.cpp
clangd/index/Index.h
clang
sammccall added a comment.
Nice! just nits
Comment at: clangd/index/SymbolFromYAML.cpp:32
+// supported in YAML I/O.
+struct NPArray {
+ NPArray(IO &) {}
what does NP stand for?
Comment at: clangd/index/SymbolFromYAML.cpp:44
+
+ std::vector
hokein created this revision.
hokein added a reviewer: sammccall.
Herald added subscribers: ilya-biryukov, mgorny, klimek.
This will be used together with https://reviews.llvm.org/D40548 for the global
index source (experimental).
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D
