[PATCH] D41129: Fix `git-clang-format `.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato added a comment. Yeah, I was incorrect. The feature worked fine. I don't know what I was thinking. https://reviews.llvm.org/D41129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41129: Fix `git-clang-format `.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato added a comment. Actually the old code might have been working fine. Please hold off on reviewing. https://reviews.llvm.org/D41129 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D41129: Fix `git-clang-format `.

2017-12-12 Thread Mark Lodato via Phabricator via cfe-commits
lodato created this revision. lodato added reviewers: djasper, klimek. This feature had never worked at all because the code incorrectly used <`commit2>` for both the "old" and "new", so the diff was always empty! Now we correctly use `` where we should and it works fine. https://reviews.llvm.