:zhen@autodesk.com>>
Cc: Benoit Belley
mailto:benoit.bel...@autodesk.com>>;
reviews+d41081+public+5a71b504a12c1...@reviews.llvm.org<mailto:reviews+d41081+public+5a71b504a12c1...@reviews.llvm.org>;
r...@google.com<mailto:r...@google.com>;
cfe-commits@lists.llvm.org<mailto
oit.bel...@autodesk.com>>
Cc:
reviews+d41081+public+5a71b504a12c1...@reviews.llvm.org<mailto:reviews%2bd41081%2bpublic%2b5a71b504a12c1...@reviews.llvm.org>;
Zhen Cao mailto:zhen@autodesk.com>>;
r...@google.com<mailto:r...@google.com>
Subject: Re: [PATCH] D41081: Fix clang Lexer W
Zhen Cao <
> zhen....@autodesk.com>; r...@google.com
>
>
> *Subject:* Re: [PATCH] D41081: Fix clang Lexer Windows line-ending bug
>
>
>
> To be honest, I'm not a fan of testing code in a way that tries to work
> around issues related to source control. I think w
: Zachary Turner [mailto:ztur...@google.com]
Sent: Monday, December 11, 2017 3:42 PM
To: Benoit Belley
Cc: reviews+d41081+public+5a71b504a12c1...@reviews.llvm.org; Zhen Cao
; r...@google.com
Subject: Re: [PATCH] D41081: Fix clang Lexer Windows line-ending bug
To be honest, I'm not a fan of te
See my other response. Maybe we don’t even need a substitution at all?
On Mon, Dec 11, 2017 at 12:24 PM Benoit Belley via Phabricator <
revi...@reviews.llvm.org> wrote:
> belleyb added inline comments.
>
>
>
> Comment at: test/lit.cfg.py:52-57
> +if platform.system() in ['Windows'
belleyb added inline comments.
Comment at: test/lit.cfg.py:52-57
+if platform.system() in ['Windows']:
+config.substitutions.append(('dos2unix', 'sed -b "s/\r$//"'))
+config.substitutions.append(('unix2dos', 'sed -b "s/\r*$/\r/"'))
+else:
+config.substitutions.append(
