This revision was automatically updated to reflect the committed changes.
Closed by commit rL322377: [clangd] Incorporate fuzzy-match into result
rankings. (authored by sammccall, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.org/D40780?v
sammccall added inline comments.
Comment at: test/clangd/completion-fuzzy.test:1
+# RUN: clangd -pretty -run-synchronously < %s | FileCheck %s
+# It is absolutely vital that this file has CRLF line endings.
hokein wrote:
> nit: any reason not using unittest `Code
sammccall updated this revision to Diff 129633.
sammccall marked an inline comment as done.
sammccall added a comment.
Unit test instead of lit test.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40780
Files:
clangd/CodeComplete.cpp
clangd/FuzzyMatch.h
clangd/Protocol.h
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
LGTM.
Comment at: test/clangd/completion-fuzzy.test:1
+# RUN: clangd -pretty -run-synchronously < %s | FileCheck %s
+# It is absolutely vital that this file has CRLF line end
sammccall updated this revision to Diff 129622.
sammccall marked 2 inline comments as done.
sammccall added a comment.
Rebase, and address comments.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40780
Files:
clangd/CodeComplete.cpp
clangd/FuzzyMatch.h
clangd/Protocol.h
sammccall marked 2 inline comments as done.
sammccall added a comment.
Tested in this file:
#include
#include
#include
int main() { std::^ }
Before this change:
u -> __has_argument_type, __has_first_argument_type...
un -> __has_argument_type, __has_first_argument_type...
u_p ->
ioeric added inline comments.
Comment at: clangd/ClangdUnit.cpp:377
+ : Result(&Result), SymbolScore(score(Result)), FilterScore(FilterScore),
+Score(FilterScore * SymbolScore) {}
It might worth mentioning how well `FilterScore * SymbolScore` perfo
sammccall created this revision.
Herald added subscribers: cfe-commits, klimek.
The scoring function is fuzzy-match-quality * existing quality score.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D40780
Files:
clangd/ClangdUnit.cpp
clangd/FuzzyMatch.h
clangd/Protocol.h
