mclow.lists added a comment.
We don't usually do this in source files, because they don't get included in
people's builds - just the library build.
if you look in src/mutex.cpp, you'll see stuff like:
`void __call_once(volatile unsigned long& flag, void* arg, void(*func)(void*))`
On the other h
halyavin updated this revision to Diff 137945.
halyavin added a comment.
update to new revision
https://reviews.llvm.org/D40775
Files:
src/support/win32/locale_win32.cpp
Index: src/support/win32/locale_win32.cpp
===
--- src/supp
halyavin added a comment.
ping.
https://reviews.llvm.org/D40775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
halyavin added a comment.
@EricWF , could you please look at this change? It doesn't have any functional
changes.
https://reviews.llvm.org/D40775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo
jroelofs added a comment.
looks fine to me, but this is the sort of thing that @EricWF usually wants the
final say on.
https://reviews.llvm.org/D40775
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/lis
halyavin updated this revision to Diff 125354.
https://reviews.llvm.org/D40775
Files:
include/support/win32/locale_win32.h
src/support/win32/locale_win32.cpp
Index: src/support/win32/locale_win32.cpp
===
--- src/support/win32/lo
jroelofs added inline comments.
Comment at: src/support/win32/locale_win32.cpp:90
+__libcpp_locale_guard __current(__loc);
va_list ap;
+va_start( ap, __format );
__ap
Comment at: src/support/win32/locale_win32.cpp:99
{
va_lis
halyavin created this revision.
Avoid possible collisions with macros.
Repository:
rCXX libc++
https://reviews.llvm.org/D40775
Files:
include/support/win32/locale_win32.h
src/support/win32/locale_win32.cpp
Index: src/support/win32/locale_win32.cpp
===
