[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-05 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rCXX319802: [libcxx] Fix intrinsics for MSVC (authored by smeenai). Repository: rCXX libc++ https://reviews.llvm.org/D40774 Files: include/algorithm Index: include/algorithm

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-05 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a subscriber: bcraig. smeenai added a comment. In https://reviews.llvm.org/D40774#945254, @halyavin wrote: > In https://reviews.llvm.org/D40774#944751, @smeenai wrote: > > > In https://reviews.llvm.org/D40774#944749, @halyavin wrote: > > > > > In https://reviews.llvm.org/D40774#9439

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-05 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin added a comment. In https://reviews.llvm.org/D40774#944751, @smeenai wrote: > In https://reviews.llvm.org/D40774#944749, @halyavin wrote: > > > In https://reviews.llvm.org/D40774#943993, @smeenai wrote: > > > > > Are you actually using libc++ with cl? :) > > > > > > People mostly use it

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-04 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. In https://reviews.llvm.org/D40774#944749, @halyavin wrote: > In https://reviews.llvm.org/D40774#943993, @smeenai wrote: > > > Are you actually using libc++ with cl? :) > > > People mostly use it to compile on Windows but I heard someone launches the > result too. Since

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-04 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin added a comment. In https://reviews.llvm.org/D40774#943993, @smeenai wrote: > Are you actually using libc++ with cl? :) People mostly use it to compile on Windows but I heard someone launches the result too. Since no one complains and it passed most of the testing, I guess the result

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-04 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai accepted this revision. smeenai added a comment. This revision is now accepted and ready to land. Are you actually using libc++ with cl? :) https://reviews.llvm.org/D40774 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.

[PATCH] D40774: [libcxx] Fix intrinsics for MSVC

2017-12-03 Thread Andrey Khalyavin via Phabricator via cfe-commits
halyavin created this revision. The parameter was previously renamed but MSVC path was not updated. https://reviews.llvm.org/D40774 Files: include/algorithm Index: include/algorithm === --- include/algorithm +++ include/algorit