mstorsjo edited subscribers, added: libcxx-commits, mstorsjo; removed:
llvm-commits, cfe-commits.
mstorsjo added a comment.
I see that @smeenai brought up the inconsistency between `_DLL` and
`_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS` already back when this was reviewed.
I'm running into problems
compnerd closed this revision.
compnerd added a comment.
SVN r319816
Repository:
rCXX libc++
https://reviews.llvm.org/D40660
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai accepted this revision.
smeenai added a comment.
This revision is now accepted and ready to land.
I think it would make sense for this change to also have the conditional for
the static C++ library selection. Basically something like
#if defined(_LIBCPP_ABI_MICROSOFT) && !defined(_LIBC
compnerd added inline comments.
Comment at: include/__config:1267
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
+# pragma comment(lib, "c++d.lib")
smeenai wrote:
> compnerd wrote:
> > smeenai wrote:
> > > I guess `_D
smeenai added a comment.
I'm fine with future proofing, but not if it doesn't actually work in the
present :)
Comment at: include/__config:1267
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
+# pragma comment(lib, "c++d.lib")
-
compnerd updated this revision to Diff 124983.
compnerd added a comment.
@rnk/@smeenai don't want future proofing
Repository:
rCXX libc++
https://reviews.llvm.org/D40660
Files:
include/__config
Index: include/__config
===
--
compnerd added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
smeenai wrote:
> rnk wrote:
> > smeenai wrote:
> > > This feels more lik
smeenai added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
rnk wrote:
> smeenai wrote:
> > This feels more like a Windows (or perhap
rnk added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
smeenai wrote:
> This feels more like a Windows (or perhaps COFF) thing than
smeenai added inline comments.
Comment at: include/__config:1266
+#if defined(_LIBCPP_ABI_MICROSOFT)
+# if defined(_DLL) && !defined(_LIBCPP_BUILDING_LIBRARY)
+# if defined(_LIBCPP_DEBUG)
This feels more like a Windows (or perhaps COFF) thing than a Microsoft A
compnerd updated this revision to Diff 124976.
compnerd added a comment.
Fix pragma, ensure that we do not try to recursively link.
https://reviews.llvm.org/D40660
Files:
include/__config
Index: include/__config
===
--- include
compnerd created this revision.
Herald added a subscriber: cfe-commits.
The MSVC driver and clang do not link against the C++ runtime
explicitly. Instead, they rely on the auto-linking via the pragma
(through `use_ansi.h`) to link against the correct version of the C++
runtime. Attempt to do som
12 matches
Mail list logo
