This revision was automatically updated to reflect the committed changes.
Closed by commit rL340521: [libclang] Fix cursors for arguments of Subscript
and Call operators (authored by yvvan, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm.or
yvvan accepted this revision.
yvvan added a comment.
This revision is now accepted and ready to land.
Let's proceed with this one. I really see that it's going to be useful.
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@li
yvvan added a comment.
Tests run fine but the solution feels like a workaround.
Nevertheless if we are sure that extending the subscript/call operator range
does not work properly or breaks too many other things than it's probably fine
to have this workaround.
https://reviews.llvm.org/D40481
nik added a comment.
Ping.
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
This one still applies and tests pass.
Please review.
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Ping...
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Ping!
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Ping...
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
New year, new hope - ping :)
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Ping.
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nik added a comment.
Ping
https://reviews.llvm.org/D40481
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yvvan added inline comments.
Comment at: tools/libclang/CIndex.cpp:6888
+ const SourceLocation fixedEnd =
+ RefNameRange.getEnd().getLocWithOffset(-1);
+ RefNameRange = SourceRange(RefNameRange.getBegin(), fixedEnd);
nik wrote:
> yvvan wrote:
>
nik marked 4 inline comments as done.
nik added inline comments.
Comment at: tools/libclang/CIndex.cpp:6888
+ const SourceLocation fixedEnd =
+ RefNameRange.getEnd().getLocWithOffset(-1);
+ RefNameRange = SourceRange(RefNameRange.getBegin(), fixedEnd);
nik updated this revision to Diff 124341.
nik added a comment.
Addressed coding style issues.
https://reviews.llvm.org/D40481
Files:
test/Index/annotate-operator-call-expr.cpp
tools/libclang/CIndex.cpp
Index: tools/libclang/CIndex.cpp
===
yvvan added inline comments.
Comment at: tools/libclang/CIndex.cpp:6445
+ struct PostChildrenAction {
+ CXCursor cursor;
+ enum Action { Invalid, Ignore, Postpone } action;
4 spaces instead of 2
Comment at: tools/libclang/CIndex.cpp:
nik created this revision.
The DeclRefExpr of CXXOperatorCallExpr refering to the custom operator
is visited before the arguments to the operator call. For the Call and
Subscript operator the range of this DeclRefExpr includes the whole call
expression, so that all tokens in that range were mapped
16 matches
Mail list logo
