[PATCH] D39430: [clangd] various fixes

2017-12-08 Thread Raoul Wols via Phabricator via cfe-commits
rwols added a comment. This differential is now split into https://reviews.llvm.org/D41031 and https://reviews.llvm.org/D40860. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39430 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D39430: [clangd] various fixes

2017-12-05 Thread Raoul Wols via Phabricator via cfe-commits
rwols added a comment. I will split this diff up into separate parts. Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D39430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co

[PATCH] D39430: [clangd] various fixes

2017-12-05 Thread Ilya Biryukov via Phabricator via cfe-commits
ilya-biryukov added a comment. In https://reviews.llvm.org/D39430#943387, @malaperle wrote: > I'd rather keep one commit per fix or feature. I would think the clang-format > part should be one commit/review on its own. But I'm not very familiar with > the practices here so I'll let others comme

[PATCH] D39430: [clangd] various fixes

2017-12-03 Thread Marc-Andre Laperle via Phabricator via cfe-commits
malaperle added a comment. > - Look up in parent directories for a .clang-format file. Use "LLVM" as > fallback style. > - Move cached fixits to ClangdServer, remove fixits once the client closes > the document. > - Fix translations between LSP rows/cols (0-based) and clang row/cols > (1-based)