george.karpenkov requested changes to this revision.
george.karpenkov added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: dmgreen.
Comment at: lib/Analysis/CFG.cpp:1348
+for (auto &Parent : ASTCtx.getParents(Node)) {
+ NodesTo
szepet added a comment.
Herald added a reviewer: george.karpenkov.
ping
https://reviews.llvm.org/D39398
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
szepet added inline comments.
Comment at: test/Analysis/loopexit-cfg-output.cpp:912-914
+// CHECK: [B5]
+// CHECK-NEXT: Succs (1): B8
+
NoQ wrote:
> P.S. This is not a regression introduced by your patch, but i'm really
> curious what does this block eve
szepet updated this revision to Diff 130503.
szepet marked 2 inline comments as done.
szepet added a comment.
Added comments and removed indirect goto support from this patch.
> This seems a bit scary because if there's no obvious one-to-once
> correspondence between entrances and exits along
NoQ added a comment.
Herald added subscribers: dkrupp, a.sidorin, rnkovacs.
These CFGs make perfect sense to me so far, and i guess this is a must-have.
Thank you!
> Note: In case of IndirectGotoStmt, it could happen that we generate LoopExit
> elements even for loops which is not exited by tha
szepet updated this revision to Diff 120726.
szepet added a comment.
Just removed some accidentally left changes from the patch.
https://reviews.llvm.org/D39398
Files:
include/clang/Analysis/CFG.h
lib/Analysis/CFG.cpp
test/Analysis/loopexit-cfg-output.cpp
Index: test/Analysis/loopexit-cf
szepet created this revision.
Herald added subscribers: baloghadamsoftware, whisperity.
This patch adds a LoopExit element to the CFG whenever a loop is exited by a
ReturnStmt, GotoStmt or IndirectGotoStmt.
The LoopExit element is consumed by the Static Analyzer in order to simulate
the loops mo
