mclow.lists added a comment.
Herald added subscribers: bixia, christof.
What we need to do here is to here is to add a new macro
`_LIBCPP_ABI_REGEX_MEMORY` in `<__config>` (around line 89) and then make these
changes available only when this macro is defined.
By default - we get no change.
If `
timshen updated this revision to Diff 120711.
timshen added a comment.
Remove the uses of variadic template and auto.
I'm not sure of how to implement this without a ABI change (the addition of
__storage_).
https://reviews.llvm.org/D39308
Files:
libcxx/include/regex
Index: libcxx/include/r
timshen added a comment.
In https://reviews.llvm.org/D39308#907424, @mclow.lists wrote:
> A couple of notes.
Sorry for the oversights, when a C++11(-only :) contributor doesn't care about
ABI stability, nor exceptions, he contributes naive code. :P I'll fix them.
> - This change means that n
mclow.lists added a comment.
I can confirm that with this patch the (large) regex that used to cause a stack
overflow does not any more.
https://reviews.llvm.org/D39308
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
mclow.lists added a comment.
A couple of notes.
- This change means that now requires C++11 (the new `__push` function
w/ the varargs). I don't know how important that is; but I'm pretty sure
libc++ currently provides `` in C++03 mode.
- This is an ABI change; existing code that was compiled
timshen updated this revision to Diff 120334.
timshen added a comment.
Add an assertion to __push.
https://reviews.llvm.org/D39308
Files:
libcxx/include/regex
Index: libcxx/include/regex
===
--- libcxx/include/regex
+++ libcxx/i
timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
Build abstraction on regex's allocation
This fixes a fuzzer crasher from a huge input (provided by Marshall), which
seems to be a stackoverflow during destruction. However, I can't reproduce
Marsh
