This revision was automatically updated to reflect the committed changes.
Closed by commit rL317192: Fix building for ARM with dwarf exception handling
(authored by mstorsjo).
Changed prior to commit:
https://reviews.llvm.org/D39251?vs=120863&id=121242#toc
Repository:
rL LLVM
https://review
mstorsjo added inline comments.
Comment at: src/Registers.hpp:1481
+ mutable uint32_t _iwmmx_control[4];
#endif
};
compnerd wrote:
> Why the change to mark these as mutable?
These are touched from within `getRegister`, but we need to make `getRegister`
const
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: src/Registers.hpp:1481
+ mutable uint32_t _iwmmx_control[4];
#endif
};
Why the change to mark these as mutable?
https://reviews.llvm
mstorsjo updated this revision to Diff 120863.
mstorsjo edited the summary of this revision.
mstorsjo added a comment.
Avoiding duplicating the highest register number, avoiding any further casts in
log lines.
https://reviews.llvm.org/D39251
Files:
include/__libunwind_config.h
include/libu
mstorsjo added inline comments.
Comment at: src/Registers.hpp:1342
}
+ static int lastDwarfRegNum() { return 287; }
mstorsjo wrote:
> compnerd wrote:
> > Can we not use `_LIBUNWIND_HIGHEST_DWARF_REGISTER` here?
> I guess we could - we could do that consist
mstorsjo added inline comments.
Comment at: src/UnwindLevel1.c:79
_LIBUNWIND_TRACE_UNWINDING(
"unwind_phase1(ex_ojb=%p): pc=0x%" PRIx64 ", start_ip=0x%" PRIx64
", func=%s, lsda=0x%" PRIx64 ", personality=0x%" PRIx64 "",
mstorsjo wrote
mstorsjo added a comment.
In https://reviews.llvm.org/D39251#906110, @compnerd wrote:
> Whats the motivation for adding DWARF based unwinding on ARM? What
> environment is using this?
AFAIK NetBSD does.
And my actual target is for MinGW/ARM; it seemed to be less effort to make
libunwind wor
compnerd added a comment.
Whats the motivation for adding DWARF based unwinding on ARM? What environment
is using this?
Comment at: src/Registers.hpp:1342
}
+ static int lastDwarfRegNum() { return 287; }
Can we not use `_LIBUNWIND_HIGHEST_DWARF_REGISTE
mstorsjo created this revision.
Herald added subscribers: kristof.beyls, aprantl, aemerson.
The previous definition of _LIBUNWIND_HIGHEST_DWARF_REGISTER seems to be a copy
of the ARM64 value (introduced in SVN r276128); since the code actually hasn't
compiled properly for arm in dwarf mode befor
