This revision was automatically updated to reflect the committed changes.
Closed by commit rL316719: [WebAssembly] Include libclang_rt.builtins in the
standard way (authored by sbc).
Changed prior to commit:
https://reviews.llvm.org/D39218?vs=120111&id=120516#toc
Repository:
rL LLVM
https:/
sbc100 updated this revision to Diff 120111.
sbc100 added a comment.
- remove debugging
- git squash commit for startup_libs.
- update test expectations
https://reviews.llvm.org/D39218
Files:
lib/Driver/ToolChain.cpp
lib/Driver/ToolChains/CommonArgs.cpp
lib/Driver/ToolChains/WebAssembly.c
dschuff accepted this revision.
dschuff added inline comments.
This revision is now accepted and ready to land.
Comment at: lib/Driver/ToolChain.cpp:318
+ else
+OSLibName = getOS();
llvm::sys::path::append(Path, "lib", OSLibName);
sbc100 wrote:
> dschuff
sbc100 added inline comments.
Comment at: lib/Driver/ToolChain.cpp:318
+ else
+OSLibName = getOS();
llvm::sys::path::append(Path, "lib", OSLibName);
dschuff wrote:
> Is this logic intended to replace what was removed from CommonArgs.cpp?
> Should there b
dschuff added inline comments.
Comment at: lib/Driver/ToolChain.cpp:318
+ else
+OSLibName = getOS();
llvm::sys::path::append(Path, "lib", OSLibName);
Is this logic intended to replace what was removed from CommonArgs.cpp? Should
there be an assert here t
