frutiger abandoned this revision.
frutiger added a comment.
Fixed by r317986.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
Thanks for the note, I'll wait.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mgorny added a comment.
I've rewritten the tests to use `unittest`, so this patch needs to be updated
now. However, you may want to wait a while since @compnerd promised to look at
it and he might have a way to get `uniqueExternal()` linkage.
https://reviews.llvm.org/D39161
mgorny added reviewers: jbcoe, aaron.ballman.
mgorny added a comment.
Let's try some more reviewers.
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
Friendly poke @rsmith @compnerd
https://reviews.llvm.org/D39161
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
I was unable to produce a simple test case that would still result in a cursor
with 'unique external' linkage. @rsmith I would appreciate if you can think of
a symbol that may still have this kind of linkage. Thanks!
https://reviews.llvm.org/D39161
__
frutiger created this revision.
In SVN r314037, linkage determination of a symbol was significantly
refactored. This resulted in extern anonymous namespace declarations to
no longer be considered 'unique_external'. This ultimately broke a test
in the Python bindings.
This commit removes the 'un
