[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-16 Thread Haojian Wu via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL315898: [clang-rename] Add function unit tests. (authored by hokein). Repository: rL LLVM https://reviews.llvm.org/D38882 Files: cfe/trunk/lib/Tooling/Refactoring/Rename/USRLocFinder.cpp cfe/trunk

[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein added inline comments. Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:469 + // name. + // FIXME: Consider using using-decls to shorten the namespace + // qualifers. ioeric wrote: > The current behavior looks fine to

[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 119128. hokein marked an inline comment as done. hokein added a comment. Remove the FIXME. https://reviews.llvm.org/D38882 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Rename/RenameClassTest.cpp uni

[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-16 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. Still LGTM Comment at: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp:469 + // name. + // FIXME: Consider using using-decls to shorten the namespace + // qualifers. The current b

[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein added a comment. Sorry, I thought I have run all the tests. The previous version broke one test in RenameClass. We still need the workaround for the `std::function` special case. I added it back, and also added a corresponding test case for renaming function, but it is currently not su

[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-16 Thread Haojian Wu via Phabricator via cfe-commits
hokein updated this revision to Diff 119121. hokein added a comment. Update, and add one unfixed testcase. https://reviews.llvm.org/D38882 Files: lib/Tooling/Refactoring/Rename/USRLocFinder.cpp unittests/Rename/CMakeLists.txt unittests/Rename/RenameClassTest.cpp unittests/Rename/RenameF

[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-13 Thread Eric Liu via Phabricator via cfe-commits
ioeric accepted this revision. ioeric added a comment. This revision is now accepted and ready to land. Lg https://reviews.llvm.org/D38882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D38882: [clang-rename] Add function unit tests.

2017-10-13 Thread Haojian Wu via Phabricator via cfe-commits
hokein created this revision. Herald added subscribers: mgorny, klimek. Also contain some fixes: - Get rid of the "TranslationUnitDecl" special case in RenameClass, as we switch to use USR instead of AST matcher to find symbols. A bonus point is that now the test cases make more sense. - Fix a