K-ballo added a comment.
Thanks @lichray
Repository:
rL LLVM
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
lichray added a comment.
That commit message generated from `arc` wasn't all that friendly :/
Thanks for the patch, and @K-ballo you should ask Chris for a commit bit :)
Repository:
rL LLVM
https://reviews.llvm.org/D38831
___
cfe-commits mailing
This revision was automatically updated to reflect the committed changes.
Closed by commit rL320509: [libcxx] P0604, invoke_result and is_invocable
(authored by lichray, committed by ).
Changed prior to commit:
https://reviews.llvm.org/D38831?vs=126545&id=126580#toc
Repository:
rL LLVM
http
K-ballo updated this revision to Diff 126545.
K-ballo added a comment.
Fixed incorrect test case.
https://reviews.llvm.org/D38831
Files:
include/type_traits
include/variant
test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
test/std/utilities/function.objects/unord.hash/non
K-ballo added a comment.
In https://reviews.llvm.org/D38831#952228, @lichray wrote:
> [...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9:
> error: static_assert failed due to requirement
> '!std::is_nothrow_invocable_r_v' ""
> static_assert(!std::is_nothrow_in
lichray added a comment.
[...]test/std/utilities/meta/meta.rel/is_nothrow_invocable.pass.cpp:118:9:
error: static_assert failed due to requirement
'!std::is_nothrow_invocable_r_v' ""
static_assert(!std::is_nothrow_invocable_r_v, "");
^ ~~
bebuch accepted this revision.
bebuch added a comment.
Please commit!
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
K-ballo added a comment.
In https://reviews.llvm.org/D38831#917439, @EricWF wrote:
> @K-ballo I always forget. Do you have commit access?
I do not. It's all yours.
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@lists.llv
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks.
@K-ballo I always forget. Do you have commit access?
https://reviews.llvm.org/D38831
___
cfe-commits mailing list
cfe-commits@list
K-ballo updated this revision to Diff 119764.
K-ballo added a comment.
Fix synopsis
https://reviews.llvm.org/D38831
Files:
include/type_traits
include/variant
test/std/utilities/function.objects/func.not_fn/not_fn.pass.cpp
test/std/utilities/function.objects/unord.hash/non_enum.pass.cpp
K-ballo created this revision.
Introduce a new form of `result_of` without function type encoding.
Rename and split `is_callable/is_nothrow_callable` into
`is_invocable/is_nothrow_invocable/is_invocable_r/is_nothrow_invocable_r` (and
associated types accordingly)
Change function type encoding
11 matches
Mail list logo
