This revision was automatically updated to reflect the committed changes.
Closed by commit rL315924: [refactor] allow the use of refactoring diagnostics
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D38772?vs=118701&id=119185#toc
Repository:
rL LLVM
https://revie
hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Looks good.
Comment at: lib/Basic/DiagnosticIDs.cpp:46
unsigned WarnShowInSystemHeader : 1;
- unsigned Category : 5;
+ unsigned Category : 6;
arphaman
arphaman added inline comments.
Comment at: lib/Basic/DiagnosticIDs.cpp:46
unsigned WarnShowInSystemHeader : 1;
- unsigned Category : 5;
+ unsigned Category : 6;
hokein wrote:
> just curious: is this change needed?
I get a build warning without this change
arphaman updated this revision to Diff 118701.
arphaman marked 2 inline comments as done.
arphaman added a comment.
- rename the common consumer class.
Repository:
rL LLVM
https://reviews.llvm.org/D38772
Files:
include/clang/Basic/AllDiagnostics.h
include/clang/Basic/CMakeLists.txt
inc
hokein added a comment.
The code looks most good to me, a few nits.
Comment at: lib/Basic/DiagnosticIDs.cpp:46
unsigned WarnShowInSystemHeader : 1;
- unsigned Category : 5;
+ unsigned Category : 6;
just curious: is this change needed?
arphaman created this revision.
Herald added a subscriber: mgorny.
This patch allows the refactoring library to use its own set of
refactoring-specific diagnostics to reports things like initiation errors.
Repository:
rL LLVM
https://reviews.llvm.org/D38772
Files:
include/clang/Basic/AllD
