This revision was automatically updated to reflect the committed changes.
Closed by commit rL315738: [clang-refactor] Apply source replacements (authored
by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D38402?vs=118471&id=118959#toc
Repository:
rL LLVM
https://reviews.llvm.o
hokein accepted this revision.
hokein added a comment.
LGTM, let's check in it.
Repository:
rL LLVM
https://reviews.llvm.org/D38402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D38402
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin
arphaman updated this revision to Diff 118471.
arphaman marked 6 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D38402
Files:
include/clang/Frontend/CommandLineSourceLoc.h
test/Refactor/tool-apply-replacements.cpp
hokein added inline comments.
Comment at: include/clang/Frontend/CommandLineSourceLoc.h:57
+ std::string FileName;
+ std::pair Begin;
+ std::pair End;
Add a comment documenting what the first element and second element of the pair
represent for (? If I unders
arphaman updated this revision to Diff 118042.
arphaman marked 5 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D38402
Files:
include/clang/Frontend/CommandLineSourceLoc.h
test/Refactor/tool-apply-replacements.cpp
arphaman added inline comments.
Comment at: test/Refactor/tool-apply-replacements.cpp:6
+
+class RenameMe { // CHECK: class {
+};
ioeric wrote:
> Why is the result `class {`?
Sorry, the test was broken. Fixed!
Repository:
rL LLVM
https://reviews.llvm.org/D38
ioeric added inline comments.
Comment at: test/Refactor/tool-apply-replacements.cpp:6
+
+class RenameMe { // CHECK: class {
+};
Why is the result `class {`?
Comment at: tools/clang-refactor/ClangRefactor.cpp:319
- // FIXME: Consume atomic ch
arphaman created this revision.
This patch actually brings clang-refactor to a usable state as it can now apply
the refactoring changes to the source files.
The `-selection` option is now also fully supported.
Repository:
rL LLVM
https://reviews.llvm.org/D38402
Files:
include/clang/Fronte
