[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

vsapsai added a comment. In https://reviews.llvm.org/D38327#882540, @jordan_rose wrote: > Nice catch, Volodymyr! Looks good to me. Thanks for the quick review, Jordan. Repository: rL LLVM https://reviews.llvm.org/D38327 ___ cfe-commits mailing

[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

This revision was automatically updated to reflect the committed changes. Closed by commit rL314473: [Sema] Put nullability fix-it after the end of the pointer. (authored by vsapsai). Changed prior to commit: https://reviews.llvm.org/D38327?vs=116861&id=117076#toc Repository: rL LLVM https:

[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

vsapsai added a comment. To preempt some of review feedback here are attempted and rejected approaches: - Pass `pointerLoc` and `pointerEndLoc` as `pointerRange`. Such source range can be misleading as `pointerLoc` doesn't necesserily point at the beginning. For example, for `int *x` pointer ra

[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

jordan_rose accepted this revision. jordan_rose added a comment. This revision is now accepted and ready to land. Nice catch, Volodymyr! Looks good to me. https://reviews.llvm.org/D38327 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http:/

[PATCH] D38327: [Sema] Put nullability fix-it after the end of the pointer.

vsapsai created this revision. Fixes nullability fix-it for `id`. With this change nullability specifier is inserted after ">" instead of between "id" and "<". rdar://problem/34260995 https://reviews.llvm.org/D38327 Files: clang/include/clang/Sema/Sema.h clang/lib/Sema/SemaType.cpp clang