frutiger closed this revision.
frutiger added a comment.
@compnerd I do now. Landed in https://reviews.llvm.org/rL316278.
https://reviews.llvm.org/D37905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
compnerd accepted this revision.
compnerd added a comment.
@frutiger you have commit rights now right?
https://reviews.llvm.org/D37905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger updated this revision to Diff 119191.
frutiger added a comment.
Added 'Location' to '__all__'.
https://reviews.llvm.org/D37905
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
tools/libclang/CXSourceLocation.cpp
Index: tools/libclang/CXSourceL
jklaehn added inline comments.
Comment at: bindings/python/clang/cindex.py:214
+class Location(object):
+"""A Location is a specific kind of source location. A SourceLocation
Can you also add `Location` to `__all__`?
https://reviews.llvm.org/D37905
__
compnerd accepted this revision.
compnerd added inline comments.
This revision is now accepted and ready to land.
Comment at: bindings/python/clang/cindex.py:320
+return self._get_spelling()['offset']
def __eq__(self, other):
frutiger wrote:
> comp
frutiger updated this revision to Diff 117041.
frutiger added a comment.
Updated as per review.
https://reviews.llvm.org/D37905
Files:
bindings/python/clang/cindex.py
bindings/python/tests/cindex/test_location.py
tools/libclang/CXSourceLocation.cpp
Index: tools/libclang/CXSourceLocation.
frutiger added inline comments.
Comment at: bindings/python/clang/cindex.py:320
+return self._get_spelling()['offset']
def __eq__(self, other):
compnerd wrote:
> Does it make sense to introduce two new properties `expansion` and `spelling`
> and h
compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.
If I'm not mistaken, the change just means that the python bindings need a
"newer" libclang, libclang's interfaces don't really change. I think that is
acceptable.
==
frutiger added a comment.
//Friendly poke!//
https://reviews.llvm.org/D37905
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
frutiger added a comment.
**Please note**:
- this change means that versions of `libclang` built prior to the introduction
of `clang_getExpansionLocation` will not work.
- this change alters the behavior of `clang_getSpellingLocation` to return the
spelling location
I would appreciate advice o
frutiger created this revision.
o) Enhance 'CursorLocation' with four additional properties that can
retrieve spelling location information.
o) Update the implementation to use 'clang_getExpansionLocation'
instead of the deprecated 'clang_getInstantiationLocation', which
has been present
11 matches
Mail list logo
