hokein added inline comments.
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
Rules.push_back(createRefactoringActionRule(
-SymbolSelectionRequirement()));
+SymbolSelectionRequirement(), OptionRequirement()));
return Rules;
--
arphaman added a comment.
In https://reviews.llvm.org/D37856#894638, @hokein wrote:
> Sorry for the delay. I saw you have reverted this commit somehow. A post
> commit.
I had some issues with ppc64/s390x bots for some reason, so I had to revert.
I'm still trying to investigate what went wrong
hokein added a comment.
Sorry for the delay. I saw you have reverted this commit somehow. A post commit.
Comment at: cfe/trunk/lib/Tooling/Refactoring/Rename/RenamingAction.cpp:113
Rules.push_back(createRefactoringActionRule(
-SymbolSelectionRequirement()));
+
arphaman added inline comments.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:73
+template
+class OptionRequirement : public RefactoringOptionsRequirement {
+public:
ioeric wrote:
> nit: `OptionRequirement` sounds more genera
This revision was automatically updated to reflect the committed changes.
arphaman marked 3 inline comments as done.
Closed by commit rL315087: [refactor] add support for refactoring options
(authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D37856?vs=117124&id=118044#toc
ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.
Looks good with some nits.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:73
+template
+class OptionRequirement : public RefactoringOptio
arphaman updated this revision to Diff 117124.
arphaman marked 10 inline comments as done.
arphaman added a comment.
Address review comments
Repository:
rL LLVM
https://reviews.llvm.org/D37856
Files:
include/clang/Tooling/Refactoring/RefactoringActionRule.h
include/clang/Tooling/Refactor
arphaman added inline comments.
Comment at:
include/clang/Tooling/Refactoring/RefactoringActionRuleRequirements.h:78
+ std::vector>
+ getRefactoringOptions() const final override {
+return {Opt};
ioeric wrote:
> Why return a vector instead of a single valu
ioeric added a comment.
Sorry for the delay (most of us are OOO this week).
Comment at: include/clang/Tooling/Refactoring/RefactoringActionRule.h:48
+
+ virtual void visitRefactoringOptions(RefactoringOptionConsumer &Consumer) =
0;
};
Please document the beh
arphaman created this revision.
This patch adds initial support for refactoring options. One can now use
optional and required `std::string` options.
The options are implemented in the following manner:
- A base interface `RefactoringOption` declares methods that describe the
option's name, de
10 matches
Mail list logo
