NoQ accepted this revision.
NoQ added a comment.
This revision is now accepted and ready to land.
Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso, dkrupp,
donat.nagy, Szelethus, mikhail.ramalho, rnkovacs, szepet, baloghadamsoftware.
This patch has already landed as rG152bc7ff
a.sidorin added a comment.
I like this refactoring. I wrote some things that are not clear for me inline.
Comment at: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp:107
+ void TryXNULock(const CallEvent &Call, CheckerContext &C) const;
+ void AcquireLockAux(const CallEven
NoQ updated this revision to Diff 115586.
NoQ added a comment.
Remove the changes in tests for now. I guess they'd need more cleanup anyway.
https://reviews.llvm.org/D37809
Files:
lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
Index: lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
===
zaks.anna added a comment.
How about committing the refactor of the code without test modifications. And
committing changes to the test separately?
https://reviews.llvm.org/D37809
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists
NoQ updated this revision to Diff 115042.
NoQ added a comment.
Don't forget to check that the function is a global C function in post-call.
https://reviews.llvm.org/D37809
Files:
lib/StaticAnalyzer/Checkers/PthreadLockChecker.cpp
test/Analysis/Inputs/system-header-simulator-for-pthread-lock
NoQ created this revision.
Use `CallEvent` and `CallDescription` everywhere. Unhardcode argument numbers
in AcquireLock() etc. Have a list of supported functions in one place. Other
misc cleanup. No functional change intended anywhere.
https://reviews.llvm.org/D37809
Files:
lib/StaticAnalyz
