This revision was automatically updated to reflect the committed changes.
Closed by commit rL312623: Debug info: Fixed faulty debug locations for
attributed statements (authored by karka).
Changed prior to commit:
https://reviews.llvm.org/D37428?vs=113803&id=113968#toc
Repository:
rL LLVM
h
Fine to remove it if it didn't change the test - it just wasn't clear to me
what exactly was being tested at the time so it was more "does this test
still work with/without -disable-llvm-passes".
No worries.
On Tue, Sep 5, 2017 at 10:58 PM Karl-Johan Karlsson via Phabricator <
revi...@reviews.llv
Ka-Ka added inline comments.
Comment at: test/CodeGen/debug-info-attributed-stmt.c:1
+// RUN: %clang_cc1 -triple x86_64-unk-unk -disable-llvm-passes
-debug-info-kind=limited -emit-llvm %s -o - | FileCheck %s
+
echristo wrote:
> Since we're not optimizing or gene
echristo added inline comments.
Comment at: test/CodeGen/debug-info-attributed-stmt.c:1
+// RUN: %clang_cc1 -triple x86_64-unk-unk -disable-llvm-passes
-debug-info-kind=limited -emit-llvm %s -o - | FileCheck %s
+
Since we're not optimizing or generating code you
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
OK, sounds good - thanks :)
https://reviews.llvm.org/D37428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi
Ka-Ka added a comment.
In https://reviews.llvm.org/D37428#861140, @dblaikie wrote:
> Not sure what you mean by "avoid emitting unnecessary stop points" - do you
> have a test case for that?
In my previous patch you could end up doing two calls to EmitStopPoint() for
the same statement. In the
dblaikie added a comment.
Not sure what you mean by "avoid emitting unnecessary stop points" - do you
have a test case for that?
https://reviews.llvm.org/D37428
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Ka-Ka updated this revision to Diff 113803.
Ka-Ka edited the summary of this revision.
Ka-Ka added a reviewer: dblaikie.
Ka-Ka added a comment.
I updated the testcase according to what David Blaikie suggested.
I also rewrote to code to be a bit more robust and avoid emitting unnecessary
stoppoint
Seems like the test case should/could be simplified a bit, maybe? (could it
be something really simple like "void f(bool b) { #pragma ... while (b) ;
}"?)
Also, is it relying on LLVM optimizations to run (add
"-disable-llvm-passes" to the command line to be sure it isn't, perhaps?)?
On Sun, Sep 3
Ka-Ka added inline comments.
Comment at: test/CodeGen/debug-info-attributed-stmt.c:18
+// CHECK: br label %while.cond, !dbg ![[NUM]], !llvm.loop
+// CHECK: ![[NUM]] = !DILocation(line: 9, scope: !14)
+}
The part "scope: !14)" should be removed from the testcase.
Ka-Ka created this revision.
Herald added a subscriber: aprantl.
As no stoppoint was generated the attributed statements got faulty debug
locations.
https://reviews.llvm.org/D37428
Files:
lib/CodeGen/CGStmt.cpp
test/CodeGen/debug-info-attributed-stmt.c
Index: test/CodeGen/debug-info-attr
11 matches
Mail list logo
