PriMee added a comment.
Great! I will work on it :)
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added a comment.
BraceWrapping.AfterExternC makes sense to me.
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PriMee added a comment.
A new style, e.g. **BraceWrapping.AfterExternC** option is what we are
considering right now. It would probably handle the problem. Leaving the line
break as is might be indeed a bad idea :)
https://reviews.llvm.org/D37260
djasper added a comment.
I am very strongly against a flag that just leaves the line break as is. What's
the motivation?
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/l
krasimir added a comment.
Yes, I meant that it should at least be controlled by a flag. However, adding
flags to clang-format requires careful consideration, we usually would accept
options that are necessary for commonly used styles with style guides and with
a community willing to support the
PriMee added a comment.
ping
https://reviews.llvm.org/D37260
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PriMee added a reviewer: krasimir.
PriMee added a subscriber: krasimir.
PriMee added a comment.
@krasimir Could you please tell me what did you mean in the comment:
> I am still not convinced about the extern part: some clients might prefer the
> other style.
Do you suggest adding a new option,
PriMee created this revision.
Herald added a subscriber: klimek.
Bug: https://bugs.llvm.org/show_bug.cgi?id=34016 - **"extern C part"**
**Problem:**
Due to the lack of "brace wrapping extern" flag, clang format does parse the
block after **extern** keyword moving the opening bracket to the head
