[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

2017-08-29 Thread Yuka Takahashi via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL312018: [Bash-autocomplete] Refactor autocomplete code into own function (authored by yamaguchi). Changed prior to commit: https://reviews.llvm.org/D37249?vs=113027&id=113118#toc Repository: rL LLVM

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

2017-08-29 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D37249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinf

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

2017-08-28 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi updated this revision to Diff 113027. yamaguchi marked an inline comment as done. yamaguchi added a comment. Update diff. I agree that this is more generic. https://reviews.llvm.org/D37249 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp Index: clang/lib/Dri

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

2017-08-28 Thread Raphael Isemann via Phabricator via cfe-commits
teemperor added inline comments. Comment at: clang/lib/Driver/Driver.cpp:1160 +void Driver::handleAutocompletions(const llvm::opt::Arg *A) const { + // Print out all options that start with a given argument. This is used for I think a more generic interface wo

[PATCH] D37249: [Bash-autocomplete] Refactor autocomplete code into own function

2017-08-28 Thread Yuka Takahashi via Phabricator via cfe-commits
yamaguchi created this revision. We wrote many codes in HandleImediateArgs, so I've refactored it into handleAutocompletions. https://reviews.llvm.org/D37249 Files: clang/include/clang/Driver/Driver.h clang/lib/Driver/Driver.cpp Index: clang/lib/Driver/Driver.cpp ==